fix(test): run release-bump smoke tests under vitest, not node:test#7
Open
farce1 wants to merge 1 commit into
Open
fix(test): run release-bump smoke tests under vitest, not node:test#7farce1 wants to merge 1 commit into
farce1 wants to merge 1 commit into
Conversation
scripts/release-bump.test.mjs imported `test` from node:test, but the vitest
config globs scripts/**/*.test.mjs — vitest found no suite and failed the run
("No test suite found"), turning the Frontend Checks CI job red. Import `test`
from vitest instead; node:assert assertions still report failures correctly.
All 6 release-bump smoke tests now run under the project suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Frontend Checks CI job (
bun run test) was failing on every branch — not a maintainer placeholder, a real bug:scripts/release-bump.test.mjsimportedtestfromnode:test, butvite.config.tsglobsscripts/**/*.test.mjsinto the vitest "node" project. vitest imported the file, found no vitest-registered suite, and failed the run (its 6 tests were silently executing under thenode:testrunner instead). The siblingscripts/benchmark-models.prompts.test.mjsalready uses vitest, so vitest is the convention.Fix
Import
testfromvitestinstead ofnode:test. Thenode:assert/strictassertions are unchanged — they throw on failure, which vitest reports as a failed test, so no assertion rewrite is needed.Verification
bun run test→ 8 files / 44 tests pass (release-bump's 6 smoke tests now run under vitest).bun run build→ succeeds (tsc + vite).This turns the Frontend Checks job green. (Rust Checks and Release Config Check remain red on the maintainer-only blockers: uncommitted
vendor/vc_redist.x64.exeand theREPLACE_WITH_SHA256/pubkey placeholders.)Code-only, no dependency changes.